Re: [Xen-devel] [PATCH 4/7] arm: map device tree blob in initial page tables

[Tim Deegan <tim@xxxxxxx>]

At 17:36 +0000 on 06 Feb (1328549779), David Vrabel wrote:
> That was already used in setup_pagetables() to relocate Xen but since
> the two uses don't overlap they can share the same slot.  Not 100% sure
> on the TLB flush after updating the L2 PTE -- it makes it work but is it
> sufficient/optimal?

Hrmn.  Yes, I think that's sufficient.  You should be able to use
flush_xen_data_tlb_va() to just flush that one entry, AFAICS.

> --- a/xen/arch/arm/head.S
> +++ b/xen/arch/arm/head.S
> @@ -201,6 +201,13 @@ hyp:
>          add   r4, r4, #8
>          strd  r2, r3, [r1, r4]       /* Map it in the fixmap's slot */
>  #endif
> +        mov   r3, #0x0
> +        lsr   r2, r8, #21
> +        lsl   r2, r2, #21            /* 2MB-aligned paddr of DTB */
> +        orr   r2, r2, #0xf00
> +        orr   r2, r2, #0x07d         /* r2:r3 := 2MB RAM incl. DTB */
> +        add   r4, r4, #8
> +        strd  r2, r3, [r1, r4]       /* Map it in the early boot slot */

That's good, but you should move the previous "add r4, r4, #8" out of
the #ifdef. :)

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel