[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vpmu: Is CONFIG_SMP used anymore?


  • To: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 08 Feb 2012 05:57:28 +0000
  • Delivery-date: Wed, 08 Feb 2012 13:58:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AczmaZfSFoZTVcyHe06fcXxBA93hNQ==
  • Thread-topic: [Xen-devel] [PATCH] vpmu: Is CONFIG_SMP used anymore?

On 08/02/2012 13:14, "Dietmar Hahn" <dietmar.hahn@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> while locking at the vpmu stuff I found the following stuff:
> 
> diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c
> --- a/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 12:28:47 2012 +0100
> +++ b/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 14:11:06 2012 +0100
> @@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
> }
>  
>  #ifndef CONFIG_SMP
> - *cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
> + *cpu_type = "i386/p4";
> model = &op_p4_spec;
> return 1;
>  #else
> 
> 
> Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.

Correct. !CONFIG_SMP isn't configurable or supported.

 -- Keir

> Thanks.
> 
> Dietmar.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.