Re: [Xen-devel] xen-4.1.3-rc1-pre changeset 23224:cccd6c68e1b9 hvm xl not execute vif-bridge when xl destroy hvmdomain or xl trigger hvmdomain power

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 9 Feb 2012, Teck Choon Giam wrote:
> Hi,
> 
> I need to check whether is this intended?  When using xl create hvm
> domains, it does execute vif-bridge script.  However, when doing xl
> destroy or xl trigger hvmdomain power it doesn't execute vif-bridge
> script.  I just did the following to test:
> 
> # cp -pvf /etc/xen/scripts/vif-bridge /etc/xen/scripts/vif-bridge.orig
> # cat > /etc/xen/scripts/vif-bridge <<'EOF'
> #!/bin/bash
> echo "$@" >> vif-bridge.log
> /etc/xen/scripts/vif-bridge.orig "$@"
> EOF
> 
> When using xm and xl to create hvmdomain, I can see vif-bridge.log
> appended with:
> 
> online type_if=vif
> online type_if=vif
> add type_if=tap
> add type_if=tap
> 
> Since I have allocated 2 vifs (one for WAN and one for LAN)... so it
> gets to execute vif-bridge once for each vif which looks right.
> 
> Now the problem is xl trigger hvmdomain power and xl destroy power.
> Both never call vif-bridge script as there isn't any such line like:
> 
> offline type_if=vif
> offline type_if=vif
> 
> Whereby when I tried with xm trigger hvmdomain power, it does call
> vif-bridge script as the above two lines get logged.
> 
> This will leave the iptables FORWARD rule intact when using xl which I
> reported before :(
> 
> See http://www.gossamer-threads.com/lists/xen/devel/204990

Actually I have just run the same test but I didn't see any issues:
vif-bridge gets called correctly when the domain dies.

It is difficult to tell what is going wrong in your case because
vif-bridge is not called directly by XL (or Xend), it is called by
vif-setup, that is called by udev when the vif network interface is
destroyed.
I suggest you check that your udev scripts are correct
(/etc/udev/rules.d/xen-backend.rules).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel