[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 03/10] libxl: do not allocate e820 for non x86 guests.

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 13 Feb 2012 17:28:17 +0000
Cc: Tim.Deegan@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Mon, 13 Feb 2012 17:28:42 +0000
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Stefano Stabellini writes ("[Xen-devel] [PATCH v2 03/10] libxl: do not allocate 
e820 for non x86 guests."):
...
> -
> +#if defined(__i386__) || defined(__x86_64__)

I would prefer to avoid these kind of platform-specific ifdefs in
libxl if possible.  I think we may need to invent libxl_x86.c or
something.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH v2 03/10] libxl: do not allocate e820 for non x86 guests.
  - From: Stefano Stabellini

References:
- [Xen-devel] [PATCH v2 00/10] arm: compile tools
  - From: Stefano Stabellini
- [Xen-devel] [PATCH v2 03/10] libxl: do not allocate e820 for non x86 guests.
  - From: Stefano Stabellini

Prev by Date: Re: [Xen-devel] [PATCH 22 of 23] libxl: idl: generate KeyedUnion key member as part of the KeyedUnion
Next by Date: Re: [Xen-devel] [PATCH v2 04/10] blktap2/libvhd: Build shared objects using -fPIC.
Previous by thread: [Xen-devel] [PATCH v2 03/10] libxl: do not allocate e820 for non x86 guests.
Next by thread: Re: [Xen-devel] [PATCH v2 03/10] libxl: do not allocate e820 for non x86 guests.
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.