Re: [Xen-devel] [PATCH 08/11] libxl: Asynchronous/long-running operation infrastructure

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 08/11] libxl: 
Asynchronous/long-running operation infrastructure"):
> 2012/1/26 Ian Jackson <ian.jackson@xxxxxxxxxxxxx>:
> > +int libxl__ao_inprogress(libxl__ao *ao)
> > +{
> > +    AO_GC;
> > +    int rc;
> 
> I've just started playing with this, but I've found that if you call
> AO_INPROGRESS without adding any event it blocks forever, and I'm not
> sure if that is a design decision or a bug. Anyway, sometimes like in
> libxl__initiate_device_remove you might call AO_INPROGRESS without
> adding any event, so I think it will be safe to add something like:

How are you expecting this ao to complete ?  If you haven't asked for
an event callback then presumably libxl__ao_complete will never be
called.

> if (!CTX->watch_counter)
>     return 0;

This is definitely wrong.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel