Re: [Xen-devel] [PATCH 0 of 4] Handling of (some) low memory conditions

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

>>>> On 16.02.12 at 04:57, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
>>>> wrote:
>> - Add a VIRQ that the hypervisor can emit when reaching a low memory
>> threshold.
>
> In this patch, which didn't make it to my inbox yet, you will want to
> change this
>
> +    if ( (total_avail_pages << PAGE_SHIFT) <= opt_low_mem_virq )
>
> to
>
>     if ( total_avail_pages <= PFN_DOWN(opt_low_mem_virq) )
>
> to avoid the case (on 32-bit hypervisors) where total_avail_pages,
> being just 'long', would get significant bits shifted out.
>
> I'm further wondering whether the default value shouldn't be set
> dynamically based on available memory and/or taking into account
> an eventual dom0_mem= option.

I can cap or get rid of the threshold (and the virq) if it doesn't make
sense with respect to total memory. I'm not sure about integrating
dom0_mem, since dom0's footprint is also a quantity manipulated by the
receiver of the virq.

>
> Finally, rate limiting will be needed for sending the vIRQ - currently,
> once below the threshold you're sending one on each and every
> allocation (which may become harmful if the listener can't really do
> anything about the situation).

All three are sensible. I'll look into printk rate-limiting for inspiration.
Thanks,
Andres
>
> Jan
>
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel