Re: [Xen-devel] [PATCH] libxl_qmp: Handle unexpected end-of-socket

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[Xen-devel] [PATCH] libxl_qmp: Handle unexpected 
end-of-socket"):
> When read() return 0, the current code just tries again. But this leads to an
> infinite loop if QEMU died too soon.

Right.

> Also, retry select if a signal was caught.

Why add another goto ?  I think these goto-based loops are a bad idea,
really.

> +            if (errno == EINTR)
> +                goto do_select_again;

I think this could be "continue".  Do you agree.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xensource.com/xen-devel