Re: [Xen-devel] [PATCH] arm: restore ELR_hyp and SPSR_hyp on return from hypervisor to hypervisor.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 21 Feb 2012, Ian Campbell wrote:
> On Tue, 2012-02-21 at 10:53 +0000, Stefano Stabellini wrote:
> > On Mon, 20 Feb 2012, Ian Campbell wrote:
> > > On Mon, 2012-02-20 at 15:22 +0000, Ian Campbell wrote:
> > > > This is necessary to handle nested traps to the hypervisor more than 
> > > > one deep.
> > > 
> > > A sort of corollary to this patch is the following.
> > > 
> > > The situation with the LR register when in hyp mode is a bit odd, since
> > > this is normally a banked register but for hyp mode it actually accesses
> > > LR_usr instead.
> > > 
> > > However, although I think the following is correct I'm not sure if it is
> > > useful to combine LR_usr and LR like this -- in particular I fear it
> > > might be more confusing than helpful. Making the return-to-user case a
> > > proper superset of return-to-hypervisor (as is the case on the save
> > > path) is nice though.
> > > 
> > > What do people think?
> > 
> > I am OK with this.
> 
> Is that an Acked-by?

with the comments, yes


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel