Re: [Xen-devel] [PATCH 1/2] libxc: pass parameters to xc_hvm_build() in a structure

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-02-29 at 12:16 +0000, David Vrabel wrote:
> On 29/02/12 12:12, Ian Campbell wrote:
> > On Tue, 2012-02-28 at 18:27 +0000, David Vrabel wrote:
> >> diff --git a/tools/libxc/xenguest.h b/tools/libxc/xenguest.h
> >> index 533e702..19b0382 100644
> >> --- a/tools/libxc/xenguest.h
> >> +++ b/tools/libxc/xenguest.h
> >> @@ -171,10 +171,23 @@ int xc_linux_build_mem(xc_interface *xch,
> >>                         unsigned int console_evtchn,
> >>                         unsigned long *console_mfn);
> >>
> >> -int xc_hvm_build(xc_interface *xch,
> >> -                 uint32_t domid,
> >> -                 int memsize,
> >> -                 const char *image_name);
> >> +struct xc_hvm_params {
> >> +    uint64_t mem_size;           /**< Memory size in bytes. */
> >> +    uint64_t mem_target;         /**< Memory target in bytes. */
> >> +    const char *image_file_name; /**< File name of the image to load.
> >> */
> >> +}; 
> > 
> > Only a minor nit but Xen already has a concept of an "HVM param" which
> > is something else. Might this be confusing?
> 
> Probably.  Suggestions for a better name?  struct xc_hvm_options?

strcut xc_hvm_build_params? Consistent with the name of the function?

> > What parses that "/**<" syntax? Don't see it anywhere else in the tree
> > apart from tools/libxl/libxlu_disk_l.h etcv which are autogenerated.
> 
> Doxygen.  I added the markers out of habit.  Shall I remove them?

I doubt we'll ever use doxygen so if you are resending you may as well.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel