Re: [Xen-devel] [PATCH DOCDAY] hcall: markup the event channel hypercalls to improve generated docs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH DOCDAY] hcall: markup the event 
channel hypercalls to improve generated docs"):
> Thanks, I didn't review closely or try it yet but this jumped out at me
> (twice):
> 
> > + if ($name eq 'buf_ioreq_t') {
> > +     print STDERR "REFHREF $type $name | $ttype $tname | @deref\n";
> > + }

I obviously wasn't having a good day that day.

> And this has a odd looking indentation:
...
> > +   } elsif (s/^(typedef \s+ )((struct|union|enum) \  (\w+))
> > +                      (\s+) (\w+)(\;)$
> > +                  / norm($1).norm($2).$5.
> > +                    defn($6,'Typedef',$6,undef,[(ucfirst $3),$4]).
> > +                    $7 /xe) {
> > +        } elsif (s/^(typedef \s+) (\w+) (\s+) (\w+) (\;)$
> 
> Extra leading space or a sneaky hard tab?

The code was full of hard tabs.  I think this needs a separate patch
to fix it up.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel