Re: [Xen-devel] [PATCH 5 of 8 v2] Linux/init: include init-functions on xencommons and xend

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH 5 of 8 v2] Linux/init: include 
init-functions on xencommons and xend"):
> Linux/init: include init-functions on xencommons and xend
> 
> Try to include /lib/lsb/init-functions on xencommons and xend or fail
> with and error message. Later patches make use of the functions
> present on this file.

Thanks.

> +# Include init script functions
> +if test -f /lib/lsb/init-functions
> +then
> +     . /lib/lsb/init-functions
> +else
> +     echo "Unable to load /lib/lsb/init-functions"
> +     exit 0
> +fi
> +

It's a shame we're not using set -e in these scripts, but in any case
this should not exit zero if it fails.  It should exit nonzero.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel