Re: [Xen-devel] [PATCH] autoconf: add missing compression checks for libxc

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.02.12 at 20:45, Roger Pau Monne <roger.pau@xxxxxxxxxxxxx> wrote:
> # HG changeset patch
> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> # Date 1329939885 -3600
> # Node ID a6f28f44a11c63f7f4a94ab49397c17279506442
> # Parent  9e72215b0ee2d73b6b60b1e155067595294dc2df
> autoconf: add missing compression checks for libxc
> 
> Move missing checks from tools/libxc/Makefile to configure script.
> 
> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>

Wow, that was fast indeed! However, ...

> --- a/tools/configure.ac      Wed Feb 22 17:49:27 2012 +0100
> +++ b/tools/configure.ac      Wed Feb 22 20:44:45 2012 +0100
> @@ -110,6 +110,10 @@ PKG_CHECK_MODULES(glib, glib-2.0)
>  AX_DEFAULT_LIB
>  
>  # Checks for libraries.
> +AC_CHECK_LIB([bz2], [BZ2_bzDecompressInit], [zlib="$zlib -DHAVE_BZLIB 
> -lbz2"])
> +AC_CHECK_LIB([lzma], [lzma_stream_decoder], [zlib="$zlib -DHAVE_LZMA 
> -llzma"])
> +AC_CHECK_LIB([lzo2], [lzo1x_decompress], [zlib="$zlib -DHAVE_LZO1X -llzo2"])

... are you certain that checking for these symbols in the respective
libraries suffices? The old check really was verifying corresponding
header files' presence.

Jan

> +AC_SUBST(zlib)
>  AC_CHECK_LIB([aio], [io_setup], [system_aio="y"], [system_aio="n"])
>  AC_SUBST(system_aio)
>  AC_CHECK_LIB([crypto], [MD5], [], [AC_MSG_ERROR([Could not find 
> libcrypto])])



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel