Re: [Xen-devel] NMI: watchdog timeout command line parameter

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On Thu, 2012-03-08 at 10:06 +0000, Jan Beulich wrote:
> >>> On 07.03.12 at 19:14, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> > Here is a patch which allows a command line parameter to set the
> > watchdog timeout.
> 
> Wouldn't it make sense to simply modify the watchdog= semantics
> slightly: When given a numeric value, it specifies the timeout (and zero
> disables as before), while when given any value parse_bool() accepts
> the timeout remains at the default and the watchdog just gets turned
> on.

I had thought of this too, but I don't think it actually simplifies it.
It makes the parsing code more complicated, and it makes the interface
actually more complicated and less predictable, for pretty much no good
reason.  It's not like adding extra command-line options is really
onerous, either in terms of users or in terms of our code.

I think it's much more important to have consistency and predictability;
the new interpretation "watchdog=1" is exactly the kind of thing we need
to avoid.

 -George

> The only ambiguity with the current possible values would be
> watchdog=1, and I think having the meaning of this changed is
> acceptable.
> 
> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel