Re: [Xen-devel] [PATCH 3 of 4] KEXEC: Allocate crash structures in low memory

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.03.12 at 15:42, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -596,7 +596,7 @@ void __init console_init_postirq(void)
>          opt_conring_size = num_present_cpus() << (9 + xenlog_lower_thresh);
>  
>      order = get_order_from_bytes(max(opt_conring_size, conring_size));
> -    while ( (ring = alloc_xenheap_pages(order, 0)) == NULL )
> +    while ( (ring = alloc_xenheap_pages(order, 
> MEMF_bits(crashinfo_maxaddr_bits))) == NULL )
>      {
>          BUG_ON(order == 0);
>          order--;

Did you note the loop here? Rather than shrinking the size, I think
you ought to ignore the address limit as the first fallback option,
in particular when the size was specified on the command line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel