Re: [Xen-devel] [PATCH] xen: Add command line option to enable ASID support -- on by default

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, Mar 13, 2012 at 4:28 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Keir Fraser writes ("Re: [Xen-devel] [PATCH] xen: Add command line option to 
> enable ASID support -- on by default"):
>> On 07/03/2012 18:14, "George Dunlap" <george.dunlap@xxxxxxxxxx> wrote:
>> > Well at very least to measure the performance benefit (or overhead) of
>> > using the feature.  There may be hardware in the future where ASIDs may
>> > cause problems; who knows.
>> >
>> > AFAICT this isn't documented anywhere, so if you really don't want Yet
>> > Another Option, we could probably get rid of it from the XenServer
>> > patchqueue.  But I didn't see any harm in it; and you never know when
>> > the flexibility of disabling something without recompiling will come in
>> > handy.
>>
>> Okay, I applied it. I also moved the implementation into hvm/asid.c by the
>> way -- your patch was unnecessarily AMD-specific.
>>
>> xen-unstable:24986
>
> Surely given that we now have a document listing the command line
> options we shouldn't be introducing new options with no documentation ?
>
> If George's original patch had come with a docs hunk it probably would
> have already contained the answers to the questions you asked, too...

When I wrote the patch I wasn't aware of the new doc file.  (IIUC it
was at most a week old at that point.)  I'll put updating it on my
to-do list.

 -George

>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel