Re: [Xen-devel] [PATCH v3 03/11] arm: support fewer LR registers than virtual irqs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-03-02 at 14:27 +0000, Stefano Stabellini wrote:
> @@ -247,6 +256,8 @@ static void __cpuinit gic_hyp_init(void)
 
>      GICH[GICH_HCR] = GICH_HCR_EN;
>      GICH[GICH_MISR] = GICH_MISR_EOI;
> +    gic.lr_mask = 0ULL;
> +    INIT_LIST_HEAD(&gic.lr_pending);


I'm not sure this is the correct place for this initialisation.

In Tim's SMP series he added a call to this from gic_init_secondary_cpu,
this made sense to me because until now this function has only
initialised the per-CPU GICH registers.

However you are now adding a global gic initialiser. I think either this
initialisation would be better off in gic_init() or we need a new
datastructure for per-CPU git information.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel