Re: [Xen-devel] [PATCH 7/8] arm: use bootargs for the command line

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 14/03/12 10:46, Ian Campbell wrote:
> On Tue, 2012-02-28 at 16:54 +0000, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@xxxxxxxxxx>
>>
>> Use the /chosen node's bootargs parameter for the Xen command line.
>> Parse it early on before the serial console is setup.
>>
>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> Looks good to me. Did you build/test the cmdline_parse change on x86 (or
> non-ARM) too?

I built it for x86, yes.  I also looked quite carefully at
cmdline_parse() -- it seems the missing const is an accidental ommision.

> Assuming that changes stands alone it might be useful to split it out
> and submit it to Keir separately.

Ok.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel