Re: [Xen-devel] [PATCH] tools/configure: correct enable/disable-feature option

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-03-14 at 19:33 +0000, Olaf Hering wrote:
> On Wed, Mar 14, Ian Campbell wrote:
> 
> > On Wed, 2012-03-14 at 18:13 +0000, Olaf Hering wrote:
> > > # HG changeset patch
> > > # User Olaf Hering <olaf@xxxxxxxxx>
> > > # Date 1331748796 -3600
> > > # Node ID 36690251f6bfe153f390ef200ff286e64f2582d7
> > > # Parent  cd473b1fb313bb107cf1c32ce224f265a5de097e
> > > tools/configure: correct enable/disable-feature option
> > > 
> > > If --disable-feature is not specified then feature should default to n.
> > 
> > Maybe I'm misunderstanding what you are saying. I'd have though that it
> > would depend on the feature whether it was on by default or not and in
> > other cases it will depend on whether the prerequisites are met.
> 
> For example, --disable-debug is supposed to be the default,

Right, what was missing from my understanding is that you were patching
a pair of macros one of which enables by default and supplies
--disable-foo and the other vice versa. I presume the right macro is
used depending on the type of the argument.

The original description would have been clearer if it has been:
        If AX_ARG_DISABLE_AND_EXPORT is used and --disable-feature is
        not specified then feature should default to n.
or so. Although now that I read it like that it seems that the macro
names are pretty confusing, since AX_ARG_DISABLE_AND_EXPORT appears to
mean "option is enabled by default so provide --disable-feature".

On that basis I think your change may be wrong -- it looks like the
intention was to enable debug by default and AX_ARG_DISABLE_AND_EXPORT
does that. I've CC'd Roger for his input.

I think those macros are very confusingly named.
AX_ARG_DEFAULT_{ENABLE,DISABLE} (or AX_ARG_DEFAULT(name,{yes|no}) might
be clearer? The _AND_EXPORT seems a bit unnecessary to me.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel