Re: [Xen-devel] [PATCH] autoconf: change python configure testing

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-03-16 at 11:41 +0000, Roger Pau Monnà wrote:
> 2012/3/16 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Thu, 2012-02-23 at 12:13 +0000, Roger Pau Monne wrote:
> >> # HG changeset patch
> >> # User Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> >> # Date 1329999113 -3600
> >> # Node ID 6688425179fdf1fb39f3093362ba8053d1ae4f21
> >> # Parent  1b68427875f7ffe3025ea13c7f6e8cf71ce54769
> >> autoconf: change python configure testing
> >>
> >> Switch from our custom m4 macro to ax_python_devel.m4 found in:
> >>
> >> http://www.gnu.org/software/autoconf-archive/ax_python_devel.html
> >>
> >> This provides the same set of test but uses python distutils instead
> >> of python-config.
> >>
> >> This change will also force users to switch from setting PYTHON env
> >> variable to using PYTHON_VERSION, which has to contain the python
> >> version to use (e.g.: '2.6'), if the user has several python versions
> >> installed and would like to use one different than the default.
> >
> > Are these env vars documented anywhere?
> >
> > Perhaps we could set PYTHON_VERSION based on PYTHON if the former is not
> > set and the later is?
> 
> Yes, I could tweak ax_python_devel.m4 a little bit to disable
> PYTHON_VERSION and continue using PYTHON (but we will depart from
> stock ax_python_devel.m4, and it should be taken into account when
> updating the macro file). I don't think allowing the user to set both
> is a good idea, could lead to misconfiguration problems, and is
> confusing to allow the user to set both PYTHON and PYTHON_VERSION.

I didn't mean both, just one or the other. e.g.
        if PYTHON_VERSION == "" && PYTHON != "":
                PYTHON_VERSION = ${PYTHON/pthon//}

PYTYHON_VERSION is preferred but PYTHON is allowed for compatibility
with old configurations.

> 
> >> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
> >>
> >> diff -r 1b68427875f7 -r 6688425179fd config/Tools.mk.in
> >> --- a/config/Tools.mk.in        Thu Mar 15 15:20:37 2012 +0000
> >> +++ b/config/Tools.mk.in        Thu Feb 23 13:11:53 2012 +0100
> >> @@ -1397,6 +1401,10 @@ Some influential environment variables:
> >>    XML         Path to xml2-config tool
> >>    BASH        Path to bash shell
> >>    XGETTEXT    Path to xgetttext tool
> >> +  PYTHON_VERSION
> >> +              The installed Python version to use, for example '2.3'. This
> >> +              string will be appended to the Python interpreter canonical
> >> +              name.
> 
> Here is the documentation, printed from `./configure --help`
> 
> >>    PKG_CONFIG  path to pkg-config utility
> >>    PKG_CONFIG_PATH
> >>                directories to add to pkg-config's search path



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel