Re: [Xen-devel] [PATCH] libxl: support for "rtc_timeoffset" and "localtime"

[Lin Ming <mlin@xxxxxxxxxxxxx>]

On Mon, Mar 19, 2012 at 10:50 AM, Teck Choon Giam
<giamteckchoon@xxxxxxxxx> wrote:
[...]
>>
>> Great!
>>
>> "same" means xl localtime/rtc_timeoffset option works same as xm, right?
>
> Yes, same here means the results of xm and xl are the same.

Nice!

>
>>
>>>
>>>>
>>>> I just realized another problem: does ->tm_gmtoff  already check
>>>> DST(day light saving) zone?
>>>
>>> This will need to ask those C experts... ... my testing didn't include
>>> changing DST/tm_isdst = 1 though.
>>> I tried to google about it and found
>>> http://unix.derkeiler.com/Newsgroups/comp.unix.programmer/2004-07/0044.html
>>> might be useful?
>>
>> Yes.
>>
>> I'll set my timezone to some US timezone which actually uses day light 
>> saving,
>> then check tm_gmtoff value.
>
> Hopefully it will be like the link I posted... it gives you the
> current offset but that is FreeBSD... ...
>
> I tested in Linux and one result as below:
>
> [x58.localdomain:/home/choon]# cp -pf /usr/share/zoneinfo/US/Eastern
> /etc/localtime
> cp: overwrite `/etc/localtime'? y
> [x58.localdomain:/home/choon]# date
> Sun Mar 18 22:45:09 EDT 2012
> [x58.localdomain:/home/choon]# ./checktimeoffset
> tm_isdst = 1
> tm_gmtoff = -14400
>
> So it is UTC-4 right?  If so, from http://en.wikipedia.org/wiki/UTC-4
> the offset does include DST?

I think so.

I'll post a v2 patch with your change added.

Thanks.

>
> Thanks.
>
> Kindest regards,
> Giam Teck Choon
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel