Re: [Xen-devel] [PATCH 15/20] libxl: include <_libxl_paths.h> in libxl_internal.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-03-16 at 16:26 +0000, Ian Jackson wrote:
> Ie, we permit general code in libxl direct access to the manifest
> constants such as XEN_RUN_DIR.  This simplifies their use in (eg)
> format strings.
> 
> This might be controversial because it will make it difficult to make
> any of these runtime-configurable later without changing lots of use
> sites.  But I don't think it's likely we'll want to do that.

I don't have any particular feeling one way or the other about this

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> For the moment, leave existing call sites of all the functions in
> libxl_paths.c unchanged.  The simplified use arrangements can be used
> in new code and when we update call sites for other reasons.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


> ---
>  tools/libxl/libxl_internal.h |    1 +
>  tools/libxl/libxl_paths.c    |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 69b6f74..983de3e 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -51,6 +51,7 @@
>  #include <xen/io/xenbus.h>
>  
>  #include "libxl.h"
> +#include "_libxl_paths.h"
>  
>  #if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1)
>  #define _hidden __attribute__((visibility("hidden")))
> diff --git a/tools/libxl/libxl_paths.c b/tools/libxl/libxl_paths.c
> index a95d29f..388b344 100644
> --- a/tools/libxl/libxl_paths.c
> +++ b/tools/libxl/libxl_paths.c
> @@ -14,7 +14,6 @@
>  
>  #include "libxl_osdeps.h" /* must come before any other headers */
>  #include "libxl_internal.h"
> -#include "_libxl_paths.h"
>  
>  const char *libxl_sbindir_path(void)
>  {



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel