Re: [Xen-devel] [PATCH 1 of 3 v2] PV-GRUB: Check for errors when applying patches to GRUB

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Matt Wilson writes ("[PATCH 1 of 3 v2] PV-GRUB: Check for errors when applying 
patches to GRUB"):
> We want to ensure that patches apply cleanly without rejects. Bail if
> patch returns a non-zero exit code.

Thanks.

>       for i in grub.patches/* ; do \
> -             patch -d $@ -p1 < $$i ; \
> +             patch -d $@ -p1 < $$i || exit 1; \
>       done

This looks correct but wouldn't it be better done with a "set -e" at
the top of the shell command ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel