Re: [Xen-devel] [PATCH 1 of 3] IOMMU: Add command line param to disable sharing of IOMMU and hap tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 21.03.12 at 20:22, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx> wrote:
> xen/drivers/passthrough/iommu.c |  2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> The default is 1, and the command line parameter sets to 1. Disabling may be
> desired if the host will contain VMs that do paging, sharing or mem access, 
> and
> won't be doing passthrough. These two features are mutually exclusive for 
> AMD
> processors.
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> 
> diff -r d7e417afcbe4 -r 642c0e6a01c2 xen/drivers/passthrough/iommu.c
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -87,6 +87,8 @@ static void __init parse_iommu_param(cha
>              iommu_dom0_strict = 1;
>          else if ( !strcmp(s, "sharept") )
>              iommu_hap_pt_share = 1;
> +        else if ( !strcmp(s, "no-sharept") )
> +            iommu_hap_pt_share = 0;

Taking the description above into consideration - why not simply
replace the pointless enabling option with the disabling one?

Jan

>  
>          s = ss + 1;
>      } while ( ss );
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel