Re: [Xen-devel] [PATCH 20/20] libxl: ao: Convert libxl_run_bootloader

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 20/20] libxl: ao: Convert 
libxl_run_bootloader"):
> > +    AC_CHECK_HEADER([libutil.h],[
> > +      AC_DEFINE([INCLUDE_LIBUTIL_H],[<libutil.h>],[libutil header file 
> > name])
> > +    ])
...
> Shouldn't you add something like this (or perhaps add the necessary
> AC_CHECK_HEADER for this headers, so we can get rid of the OS
> conditional include dependency):
> 
> #if defined(__NetBSD__) || defined(__OpenBSD__)
> #include <util.h>
> #elif defined(__linux__)
> #include <pty.h>
> #elif defined(__sun__)
> #include <stropts.h>
> #endif
> #include <utmp.h>

No, I don't think so.  Currently the only two platforms we really
support are *BSD and Linux, and I think what I have (include
<libutil.h> if it exists, and nothing non-portable otherwise) is
correct.

Does this test not work on *BSD ?

Certainly we don't want these kind of os-specific #ifdefs.  If there
are multiple possible headers we should call AC_CHECK_HEADER for them.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel