Re: [Xen-devel] [xen-unstable test] 11946: regressions - FAIL

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.03.12 at 12:36, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>> # HG changeset patch
>> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
>> # Date 1329216241 0
>> # Node ID 738424a5e5a5053c75cfbe64f6675b5d756daf1b
>> # Parent  0ba87b95e80bae059fe70b4b117dcc409f2471ef
>> xen: don't try to print IRQ SSID in IRQ debug from irq context.
>> 
>> It is not possible to call xfree() in that context.
>> 
>> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> 
>> diff -r 0ba87b95e80b -r 738424a5e5a5 xen/arch/x86/irq.c
>> --- a/xen/arch/x86/irq.c     Mon Feb 13 17:26:08 2012 +0000
>> +++ b/xen/arch/x86/irq.c     Tue Feb 14 10:44:01 2012 +0000
>> @@ -2026,7 +2026,7 @@ static void dump_irqs(unsigned char key)
>>          if ( !irq_desc_initialized(desc) || desc->handler == &no_irq_type )
>>              continue;
>>  
>> -        ssid = xsm_show_irq_sid(irq);
>> +        ssid = in_irq() ? NULL : xsm_show_irq_sid(irq);
>>  
>>          spin_lock_irqsave(&desc->lock, flags);
>>  
>> @@ -2073,7 +2073,8 @@ static void dump_irqs(unsigned char key)
>>  
>>          spin_unlock_irqrestore(&desc->lock, flags);
>>  
>> -        xfree(ssid);
>> +        if ( ssid )
>> +                xfree(ssid);

But perhaps xfree(NULL) should be made usable in any context (i.e.
the assertion in there moved down)? Otherwise the construct above
is likely to get collapsed again at some point with "xfree(NULL) is
perfectly valid" in mind.

Jan

>>      }
>>  
>>      dump_ioapic_irq_info();



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel