Re: [Xen-devel] [PATCH 1 of 3] IOMMU: Add command line param to disable sharing of IOMMU and hap tables

[Tim Deegan <tim@xxxxxxx>]

At 11:57 +0100 on 29 Mar (1333022256), Keir Fraser wrote:
> On 29/03/2012 11:27, "Tim Deegan" <tim@xxxxxxx> wrote:
> 
> > At 08:19 -0700 on 27 Mar (1332836366), Andres Lagar-Cavilla wrote:
> >>> At 10:57 +0000 on 22 Mar (1332413830), Jan Beulich wrote:
> >>>>>          if ( !parse_bool(s) )
> >>>>> -            iommu_enabled = 0;
> >>>>> +            iommu_enabled = val;
> >>>> 
> >>>> ... this one must remain unchanged, and the handling of the "no-"
> >>>> prefix should come afterwards.
> >>> 
> >>> Meh.  I reserve the right to set 'iommu=no-yes'. :)
> >>> That is to say, I don't think it makes any real difference.
> >> 
> >> Well, it'd be great if one version or the other goes in before 4.2 closes 
> >> :)
> > 
> > OK, here's a version that keeps the 'iommu_enabled = 0' (so we never
> > turn it _on_ in this function).  Jan, does that address your concern?
> > 
> > Any IOMMU maintainers have an opinion about this patch?
> > 
> > Keir, I think you're maintainer for this file - can I get an Ack?
> 
> Why does workaround_bios_bug not respect val like all the other options?

Oversight.  I've changed it to '= val' too.

> Apart from that:
> Acked-by: Keir Fraser <keir@xxxxxxx>

Ta.  Applied, with that one change. 

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel