Re: [Xen-devel] backport requests for 4.x-testing

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Sat, 24 Mar 2012, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 06, 2012 at 11:04:13AM +0000, Andrew Cooper wrote:
> > On 06/03/12 10:13, Jan Beulich wrote:
> > > For a (hopefully soon) upcoming 4.1.3 and 4.0.4, may I ask to consider
> > > the following changesets from -unstable for backporting:
> 
> And also these:
> 24140 tools: xend: tolerate empty state/*.xml
> 23412 libxc: xc_domain_set_memory_map, xc_get_machine_memory_map (x86, amd64 
> only)
> 23632 libxc: Squash xc_e820.h (and delete) into xenctrl.h
> 23225 x86: make the pv-only e820 array be dynamic.
> 23426 libxl: Add support for passing in the host's E820 for PCI passthrough
> 23428 libxl: Add 'e820_host' option to config file.
> 23427 libxl: Convert E820_UNUSABLE and E820_RAM to E820_UNUSABLE as 
> appropriate.
> 24013 x86,hvm: enable VCPUOP_register_vcpu_info op in hvm hypercall
 
What about:

xen: introduce PHYSDEVOP_pirq_eoi_gmfn_v2

backport appended.

---

linux/xen: support pirq_eoi_map

The pirq_eoi_map is a bitmap offered by Xen to check which pirqs need to
be EOI'd without having to issue an hypercall every time.
We use PHYSDEVOP_pirq_eoi_gmfn_v2 to map the bitmap, then if we
succeed we use pirq_eoi_map to check whether pirqs need eoi.


Changes in v2:

- explicitly use PHYSDEVOP_pirq_eoi_gmfn_v2 rather than
PHYSDEVOP_pirq_eoi_gmfn;

- introduce pirq_check_eoi_map, a function to check if a pirq needs an
eoi using the map;

-rename pirq_needs_eoi into pirq_needs_eoi_flag;

- introduce a function pointer called pirq_needs_eoi that is going to be
set to the right implementation depending on the availability of
PHYSDEVOP_pirq_eoi_gmfn_v2.


Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
---
 drivers/xen/events.c            |   26 +++++++++++++++++++++++---
 include/xen/interface/physdev.h |   21 +++++++++++++++++++++
 2 files changed, 44 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 6e075cd..cc5fc40 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -37,6 +37,7 @@
 #include <asm/idle.h>
 #include <asm/io_apic.h>
 #include <asm/sync_bitops.h>
+#include <asm/xen/page.h>
 #include <asm/xen/pci.h>
 #include <asm/xen/hypercall.h>
 #include <asm/xen/hypervisor.h>
@@ -108,6 +109,8 @@ struct irq_info {
 #define PIRQ_SHAREABLE (1 << 1)
 
 static int *evtchn_to_irq;
+static unsigned long *pirq_eoi_map;
+static bool (*pirq_needs_eoi)(unsigned irq);
 
 static DEFINE_PER_CPU(unsigned long [NR_EVENT_CHANNELS/BITS_PER_LONG],
                      cpu_evtchn_mask);
@@ -268,10 +271,14 @@ static unsigned int cpu_from_evtchn(unsigned int evtchn)
        return ret;
 }
 
-static bool pirq_needs_eoi(unsigned irq)
+static bool pirq_check_eoi_map(unsigned irq)
 {
-       struct irq_info *info = info_for_irq(irq);
+       return test_bit(irq, pirq_eoi_map);
+}
 
+static bool pirq_needs_eoi_flag(unsigned irq)
+{
+       struct irq_info *info = info_for_irq(irq);
        BUG_ON(info->type != IRQT_PIRQ);
 
        return info->u.pirq.flags & PIRQ_NEEDS_EOI;
@@ -1693,7 +1700,7 @@ void xen_callback_vector(void) {}
 
 void __init xen_init_IRQ(void)
 {
-       int i;
+       int i, rc;
 
        evtchn_to_irq = kcalloc(NR_EVENT_CHANNELS, sizeof(*evtchn_to_irq),
                                    GFP_KERNEL);
@@ -1707,6 +1714,8 @@ void __init xen_init_IRQ(void)
        for (i = 0; i < NR_EVENT_CHANNELS; i++)
                mask_evtchn(i);
 
+       pirq_needs_eoi = pirq_needs_eoi_flag;
+
        if (xen_hvm_domain()) {
                xen_callback_vector();
                native_init_IRQ();
@@ -1714,8 +1723,19 @@ void __init xen_init_IRQ(void)
                 * __acpi_register_gsi can point at the right function */
                pci_xen_hvm_init();
        } else {
+               struct physdev_pirq_eoi_gmfn eoi_gmfn;
+
                irq_ctx_init(smp_processor_id());
                if (xen_initial_domain())
                        pci_xen_initial_domain();
+
+               pirq_eoi_map = (void *)__get_free_page(GFP_KERNEL|__GFP_ZERO);
+               eoi_gmfn.gmfn = virt_to_mfn(pirq_eoi_map);
+               rc = HYPERVISOR_physdev_op(PHYSDEVOP_pirq_eoi_gmfn_v2, 
&eoi_gmfn);
+               if (rc != 0) {
+                       free_page((unsigned long) pirq_eoi_map);
+                       pirq_eoi_map = NULL;
+               } else
+                       pirq_needs_eoi = pirq_check_eoi_map;
        }
 }
diff --git a/include/xen/interface/physdev.h b/include/xen/interface/physdev.h
index c1080d9..1775722 100644
--- a/include/xen/interface/physdev.h
+++ b/include/xen/interface/physdev.h
@@ -39,6 +39,27 @@ struct physdev_eoi {
 };
 
 /*
+ * Register a shared page for the hypervisor to indicate whether the guest
+ * must issue PHYSDEVOP_eoi. The semantics of PHYSDEVOP_eoi change slightly
+ * once the guest used this function in that the associated event channel
+ * will automatically get unmasked. The page registered is used as a bit
+ * array indexed by Xen's PIRQ value.
+ */
+#define PHYSDEVOP_pirq_eoi_gmfn_v1       17
+/*
+ * Register a shared page for the hypervisor to indicate whether the
+ * guest must issue PHYSDEVOP_eoi. This hypercall is very similar to
+ * PHYSDEVOP_pirq_eoi_gmfn_v1 but it doesn't change the semantics of
+ * PHYSDEVOP_eoi. The page registered is used as a bit array indexed by
+ * Xen's PIRQ value.
+ */
+#define PHYSDEVOP_pirq_eoi_gmfn_v2       28
+struct physdev_pirq_eoi_gmfn {
+    /* IN */
+    unsigned long gmfn;
+};
+
+/*
  * Query the status of an IRQ line.
  * @arg == pointer to physdev_irq_status_query structure.
  */
-- 
1.7.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel