Re: [Xen-devel] [PATCH 0 of 2] Support for Paging/Sharing on AMD

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Mar 29, Tim Deegan wrote:

> At 18:01 +0200 on 29 Mar (1333044093), Olaf Hering wrote:
> > On Thu, Mar 29, Tim Deegan wrote:
> > 
> > > That is, can we just drop this whole test?
> > 
> > I'm ok with removing the existing boot_cpu_data.x86_vendor test,
> > check only hap_enabled() and return -ENODEV otherwise.
> > 
> > A recent change added need_iommu() check, this should be moved up into
> > the -ENODEV case becasue -EXDEV is for PoD.
> 
> That seems strange -- why would 'no; this VM uses PoD' be different from
> 'no; this VM uses the IOMMU'?

Its just a made-up return code to have a proper error message in
xenpagings init function.

> I'll take a patch to change the return code if it also documents it in
> the hypercall interface. :)

Where is it documented?

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel