Re: [Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Apr 03, Ian Campbell wrote:

> On Mon, 2012-04-02 at 20:54 +0100, Olaf Hering wrote:
> > On Mon, Apr 02, Ian Jackson wrote:
> > 
> > > Olaf Hering writes ("[Xen-devel] [PATCH 10 of 18] tools/libvchan: fix 
> > > build errors caused by -Werror in node-select.c"):
> > > > node-select.c: In function 'vchan_wr':
> > > > node-select.c:60:2: warning: ISO C90 forbids mixed declarations and 
> > > > code [-Wdeclaration-after-statement]
> > > 
> > > This one is a question of coding style.  Apparently libvchan uses
> > > mixed statements/declarations, so this should be fixed by changing the
> > > warning flags.

> However skimming over node-select.c and io.c (as another random file) it
> looks like the use of mixed declarations and code is the exception not
> the rule even within libvchan, so I think it would be fine to fix the
> two places where this isn't the case.

If thats ok with IanJ as well, I will prepare another patch to fix just
that warning in node-select.c

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel