Re: [Xen-devel] [PATCH v2] Autoconf: add variable for pass arbitrary options to qemu upstream

[Roger Pau Monne <roger.paumonne@xxxxxxxxxx>]

El 04/04/2012, a las 14:30, Fabio Fantoni escribió:
> Autoconf: add variable for pass arbitrary options to qemu upstream v2
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxxxxx>

(I'm gonna expand some of the pieces of the patch to comment them)

[...]

--- a/tools/configure   mer apr 04 14:36:16 2012 +0200
+++ b/tools/configure   mer apr 04 15:10:26 2012 +0200
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.67 for Xen Hypervisor 4.2.
+# Generated by GNU Autoconf 2.68 for Xen Hypervisor 4.2.

You should use autoconf 2.67 to update the configure script.

[...]

--- a/tools/configure.ac        mer apr 04 14:36:16 2012 +0200
+++ b/tools/configure.ac        mer apr 04 15:10:26 2012 +0200
@@ -44,6 +44,16 @@
 AX_ARG_DEFAULT_DISABLE([miniterm], [Enable miniterm])
 AX_ARG_DEFAULT_DISABLE([lomount], [Enable lomount])
 AX_ARG_DEFAULT_ENABLE([debug], [Disable debug build of tools])
+AC_ARG_ENABLE([qemuu-spice],
+[  --enable-qemuu-spice        Enable Spice build on qemu upstream],
+[qemuu_add_par+=" --enable-spice"])
+AC_ARG_ENABLE([qemuu-usbredir],
+[  --enable-qemuu-usbredir     Enable usb redirection build on qemu upstream],
+[qemuu_add_par+=" --enable-usb-redir"])
+AC_ARG_ENABLE([qemuu-debug],
+[  --enable-qemuu-debug        Enable debug build on qemu upstream],
+[qemuu_add_par+=" --enable-debug"])
+AC_SUBST(qemuu_add_par)

Why don't you use AX_ARG_DEFAULT_DISABLE or AX_ARG_DEFAULT_ENABLE?

Take a look at:

http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/249b2eeeeae5

This is still not on the main repository, but it won't take long, so I suggest 
that you base your patch on top of this change.

> 
> Patch attached.
> <autoconf_add_arbitrary_options_qemuu_v2.patch><smime.p7s>_______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel