Re: [Xen-devel] [PATCH 01 of 10 [RFC]] libxc: Generalize xenctl_cpumap to just xenctl_map

[Dario Faggioli <raistlin@xxxxxxxx>]

On Wed, 2012-04-11 at 18:31 +0200, Dario Faggioli wrote:
> > >   /* Copy to/from cpumap provided by control tools. */
> > > -struct xenctl_cpumap;
> > > -int cpumask_to_xenctl_cpumap(struct xenctl_cpumap *, const cpumask_t *);
> > > -int xenctl_cpumap_to_cpumask(cpumask_var_t *, const struct xenctl_cpumap 
> > > *);
> > > +struct xenctl_map;
> > > +int cpumask_to_xenctl_cpumap(struct xenctl_map *, const cpumask_t *);
> > > +int xenctl_cpumap_to_cpumask(cpumask_var_t *, const struct xenctl_map *);
> > You should probably s/cpumap/map/; in the function names as well.
> >
> Well, I retained the old name as the callers expect to use these
> functions as that old name says, i.e., passing a cpumap and wanting a
> cpumask back (for the first one). 
I obviously meant for the _second_ one here. :-P

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel