Re: [Xen-devel] [PATCH 04/20] autoconf: New test for openpty et al.

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

El 16/04/2012, a las 11:35, Ian Jackson escribió:
> Roger Pau Monne writes ("Re: [Xen-devel] [PATCH 04/20] autoconf: New test for 
> openpty et al."):
>>> +#ifdef INCLUDE_LIBUTIL_H
>>> +#include INCLUDE_LIBUTIL_H
>>> +#endif
>>> +
>> 
>> Maybe I'm missing something, because this autoconf macros are hard to read, 
>> but shouldn't you add something like
>> 
>> #undef INCLUDE_LIBUTIL_H
>> 
>> to tools/config.h.in, so the generated config.h contains this define?
> 
> Yes.  This is normally done by autoheader, which is normally done by
> autogen.sh.  But I see that we aren't running autoheader.  I will see
> about fixing that.
> 

Autoheader was adding a lot of stuff which we weren't using, so I preferred to 
keep config.h.in (and config.h) with just the defines we really need.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel