Re: [Xen-devel] [PATCH] libxl: add a dummy ao_how to libxl_domain_core_dump

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-04-16 at 16:50 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] libxl: add a dummy ao_how to 
> libxl_domain_core_dump"):
> > libxl: add a dummy ao_how to libxl_domain_core_dump
> > 
> > Although this function is not currently slow it may become so in the future
> > (this also depends somewhat on the size of the guest).  Therefore arrange 
> > for
> > it to take an ao_how which it completes immediately.  This will allow us to
> > make it asynchronous in the future without breaking API compatibility.
> ...
> >      ret = xc_domain_dumpcore(ctx->xch, domid, filename);
> >      if (ret<0) {
> >          LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "core dumping domain %d to 
> > %s",
> >                       domid, filename);
> > -        return ERROR_FAIL;
> > +        rc = ERROR_FAIL;
> 
> While you're doing that, did you want to change it to use "goto out" ?

wouldn't the "out:" be immediately after this immediately following
closing brace?

> >      }
> > -    return 0;
> > +
> > +    libxl__ao_complete(egc, ao, rc);
> > +
> > +    return AO_INPROGRESS;
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel