Re: [Xen-devel] [PATCH v3 3/5] libxl: call hotplug scripts from libxl for vbd

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v3 3/5] libxl: call hotplug 
scripts from libxl     for vbd"):
> I think it is important in the context of this patch to be clear about
> what is the desired long term behaviour compared with the short term
> behaviour being implemented for 4.2 is. We should also be clear about
> what is being done now in order to address xl regressions vs xend. We
> should also be clear about what is just papering over an issue for 4.2
> vs what the proper fix in 4.3 will be. We also need to know what is
> actually new functionality or behaviour (i.e. not fixing an xl vs xend
> regression). IOW we need to have clear descriptions of the reasons for
> the changes not just what the changes.

Yes.

> I think all the above need to be written down explicitly in either the
> commit message or the introductory email, otherwise the review of this
> series is just going to continue to go round in circles -- the reasoning
> behind these changes is just too complex for a reviewer (even one who is
> familiar with all this stuff already) to hold in their head.

Quite...

> > Also: this xenstore path should be a relative path, ie one relative to
> > the xenstore home of domain running this part of the tools.  That way
> > the scripts can be easily and automatically disabled for dom0 and
> > enabled in driver domains.
> 
> XENBUS_PATH contains elements for both the back- and frontend domains as
> well as the specific device.
> 
> Or do you think the key should be global per-(backend-domain rather than
> per-device?

The latter.

> > These names are rather too generic, I think.
> 
> enums should also be declared in lixl_types_internal.idl

Surely an enum which doesn't escape from inside libxl and which never
needs to be printed can just be an enum ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel