Re: [Xen-devel] [PATCH v2] libxl/build: print a warning if flex/bison are needed

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v2] libxl/build: print a warning if flex/bison 
are needed"):
> This patch adds better support for both Flex and Bison, which might
> be needed to compile libxl. Now configure script sets BISON and FLEX
> Makefile vars if bison and flex are found, but doesn't complain if
> they are not found.
> 
> Also, added some Makefile soccery to print a warning message if
> Bison or Flex are needed but not found.

Marvellous.  I have applied this.  I altered the warning message
slightly:

 +ifeq ($(FLEX),)
 +%.c %.h:: %.l
-+      $(warning Flex is needed to compile libxl, please install it and rerun \
-+      configure)
++      $(warning Flex is needed to rebuild some libxl parsers and \
++                scanners, please install it and rerun configure)
 +endif
 +
 +ifeq ($(BISON),)
 +%.c %.h:: %.y
-+      $(warning Bison is needed to compile libxl, please install it an rerun \
-+      configure)
++      $(warning Bison is needed to rebuild some libxl parsers and \
++                scanners, please install it an rerun configure)
 +endif
 +

I trust that's OK.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel