[Xen-devel] Fwd: Xen-4.1-testing fails to "make tools"

[misiu godfrey <misiu.godfrey@xxxxxxxxx>]

From: misiu godfrey <misiu.godfrey@xxxxxxxxx>
Date: Fri, 27 Apr 2012 12:41:28 -0400
Subject: Re: [Xen-devel] Xen-4.1-testing fails to "make tools"
To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

On 4/27/12, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>
> If you cd into the ioemu-remote dir then what do:
>       git show a2d2123a7dfc4d116011d51f48df786a3b853537
>       git show origin/master
> say?

For the following results I assume "ioemu-remote dir" refers to
"ioemu-remote.tmp, as there is no such directory "ioemu-remote"
present.  My file listing is as shown:

root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools# ls
blktap         debugger  include           libxen    ocaml     security
vtpm_manager  xenpaging  xm-test
blktap2        examples  ioemu-remote.tmp  libxl     pygrub    sv       
xcutils       xenpmd
check          firmware  libaio            Makefile  python    tests    
xenbackendd   xenstat
console        flask     libfsimage        memshr    remus     vnet     
xenballoon    xenstore
cross-install  hotplug   libxc             misc      Rules.mk  vtpm      xenmon
   xentrace

root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools# cd ioemu-remote.tmp/

root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools/ioemu-remote.tmp#
git show a2d2123a7dfc4d116011d51f48df786a3b853537
fatal: bad object a2d2123a7dfc4d116011d51f48df786a3b853537

root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools/ioemu-remote.tmp#
git show origin/master
commit 06d2e688405932841e9a1c27e2eaaef315298a66
Author: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date:   Thu Mar 1 18:58:27 2012 +0000

    qemu-xen: ignore console disconnect events for console/0

    The first console has a different location compared to other PV devices
    (console, rather than device/console/0) and doesn't obey the xenstore
    state protocol. We already special case the first console in con_init
    and con_initialise, we should also do it in con_disconnect.

    This patch should be applied to 4.1 too.

    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    (cherry picked from commit 2503d4d5a29e7af8dffd1e11229e11c1917d2ccf)

diff --git a/hw/xen_console.c b/hw/xen_console.c
index 0a2374c..f036b8d 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -253,6 +253,8 @@ static void con_disconnect(struct XenDevice *xendev)
 {
     struct XenConsole *con = container_of(xendev, struct XenConsole, xendev);

+    if (!xendev->dev)
+        return;
     if (con->chr)
         qemu_chr_add_handlers(con->chr, NULL, NULL, NULL, NULL);
     xen_be_unbind_evtchn(&con->xendev);
(END)


> What happens if you then run "git fetch origin" in that dir?

"git fetch origin" seems to complete without any feedback, as shown:
root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools/ioemu-remote.tmp#
git fetch origin
root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg/tools/ioemu-remote.tmp#


> From the top-level what does "make tools/ioemu-dir-force-update" do?

root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg# make
tools/ioemu-dir-force-update
make -C tools ioemu-dir-force-update
make[1]: Entering directory `/home/misiu/Xen/xen-4.1-testing.hg/tools'
set -ex; \
        if [ "a2d2123a7dfc4d116011d51f48df786a3b853537" ]; then \
                cd ioemu-remote; \
                git fetch origin; \
                git reset --hard a2d2123a7dfc4d116011d51f48df786a3b853537; \
        fi
+ [ a2d2123a7dfc4d116011d51f48df786a3b853537 ]
+ cd ioemu-remote
cd: 1: can't cd to ioemu-remote
make[1]: *** [ioemu-dir-force-update] Error 2
make[1]: Leaving directory `/home/misiu/Xen/xen-4.1-testing.hg/tools'
make: *** [tools/ioemu-dir-force-update] Error 2
root@godfrey2:/home/misiu/Xen/xen-4.1-testing.hg#


> Last resort you could try nuking the ioemu-remote dir and rebuilding.

I removed the ioemu-remote.tmp dir and remade to the same result.

Misiu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel