Re: [Xen-devel] [xen-unstable test] 11946: regressions - FAIL

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

>> The attached patch should prevent this panic
> This is effectively the same as my patch from
> <1332844592.25560.9.camel@xxxxxxxxxxxxxxxxxxxxxx>. I think "if (ssid)
> xfree(...)" is preferable to "if (in_irq()) xfree(...)" but not enough
> to prevent me:
>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> If the debug code is going to stay for 4.2 then IMHO we should also take
> this patch to make it actually useful. Otherwise we should just revert
> the original debug patch before the release.
>
>

Yes - I was thinking the same.  I suggest that when xen-4.2-testing.hg
gets branched off unstable, this debugging gets put back to just being
an assert as before.  However, I am quite unsure as to what would happen
with interrupts following that failed assert.

I shall re-do the patch.  I think it is a fairly sensible patch to have
in even after the main debugging has been removed, especially if similar
debugging needs to be done in the future.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel