[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] x86: adjust handling of interrupts coming in via legacy vectors


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Mon, 14 May 2012 17:24:30 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 14 May 2012 16:26:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac0x7gnMW9+jTaou0EGzQFknULJm8A==
  • Thread-topic: [Xen-devel] x86: adjust handling of interrupts coming in via legacy vectors

On 14/05/2012 16:56, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Looks sensible, and I suppose good to have for 4.2.
>> 
>> Acked-by: Keir Fraser <keir@xxxxxxx>
> 
> Please take a look at the v2 I just sent, to accommodate a suggestion
> from Andrew Cooper.

I think it's very paranoid, since legacy vectors never get programmed into
an IOAPIC RTE and should never need EOIing at the local APIC. But you do at
least printk the case that we see the ISR bit set, and you printk the vector
number, so really this v2 patch gives us more information about this bogus
situation than v1 did, so it's a slight improvement overall. So you still
have my Ack.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.