Re: [Xen-devel] [PATCH] libxl: build fix

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-05-16 at 16:51 +0100, Christoph Egger wrote:
> Fix this build error:
> 
> libxl_aoutils.c: In function 'libxl__openptys':
> libxl_aoutils.c:281:13: error: passing argument 4 of 'openpty' discards
> qualifiers from pointer target type
> /usr/include/util.h:92:6: note: expected 'struct termios *' but argument
> is of type 'const struct termios *'
> libxl_aoutils.c:281:13: error: passing argument 5 of 'openpty' discards
> qualifiers from pointer target type
> /usr/include/util.h:92:6: note: expected 'struct winsize *' but argument
> is of type 'const struct winsize *'
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Applied, thanks.

I improved your commit message to:

   libxl: fix build on platforms where openpty's parameters are not const.
    
    Such as NetBSD. Fixes this build error:
    
        ....

Please try and make the summary line contain some useful info, it's all
you see in the default "hg log" etc.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel