Re: [Xen-devel] [PATCH v6 04/11] libxl: move libxl__device_from_disk to libxl_internal.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-05-18 at 15:55 +0100, Roger Pau Monne wrote:
> > @@ -429,6 +429,46 @@ libxl_device_model_version
> libxl__device_model_version_running(libxl__gc *gc,
> >       return value;
> >   }
> >
> > +int libxl__device_from_disk(libxl__gc *gc, uint32_t domid,
> > +                                   libxl_device_disk *disk,
> > +                                   libxl__device *device)
> 
> I think this should be moved to libxl_device instead of
> libxl_internal, since it's a device related function. 

I think it'd be better to leave it in the original file, libxl is so
confused about what goes where that it doesn't really matter...

If we do want to move it we can do it later as a pure code motion
change.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel