Re: [Xen-devel] [PATCH v2 09/15] libxl: convert libxl_device_nic_add to an async operation

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v2 09/15] libxl: convert libxl_device_nic_add to an 
> async operation"):
> > This patch converts libxl_device_nic_add to an ao operation that
> > waits for device backend to reach state XenbusStateInitWait and then
> > marks the operation as completed. This is not really useful now, but
> > will be used by latter patches that will launch hotplug scripts after
> > we reached the desired xenbus state.
> Isn't this patch very very similar to the previous one, just with
> "nic" instead of "disk" in a lot of places ?
>
> I'm allergic to repetition and these parts of the series seem to be
> adding a lot of near-copies of the same code.
Yes, it's mostly the same, but on different points of domain/stubdomain 
creation.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel