Re: [Xen-devel] [PATCH 4/4] xen/events: Add WARN_ON when quick lookup found invalid type.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, May 25, 2012 at 10:19:10AM +0100, Stefano Stabellini wrote:
> On Fri, 25 May 2012, Stefano Stabellini wrote:
> > > @@ -939,8 +944,10 @@ int bind_virq_to_irq(unsigned int virq, unsigned int 
> > > cpu)
> > >           xen_irq_info_virq_init(cpu, irq, evtchn, virq);
> > >  
> > >           bind_evtchn_to_cpu(evtchn, cpu);
> > > + } else {
> > > +         struct irq_info *info = info_for_irq(irq);
> > > +         WARN_ON(info == NULL || info->type != IRQT_VIRQ);
> > >   }
> > > -
> > >  out:
> > >   mutex_unlock(&irq_mapping_update_lock);
> > >  
> > 
> > I don't want to nitpick but you removed 2 out of 3 spaced before the out
> > label.
> 
> I meant newlines.

Good eyes! The final version will have those unmolested.

> 
> > In any case:
> > 
> > Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel