Re: [Xen-devel] [PATCH 12/15] xl: Handle return value from libxl_domain_suspend correctly

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-05-30 at 17:16 +0100, Ian Jackson wrote:
> libxl_domain_suspend returns a libxl error code.  So it must be
> wrapped with MUST and not CHK_ERRNO.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/xl_cmdimpl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 9b4a80e..8c5f147 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -2820,7 +2820,7 @@ static int save_domain(const char *p, const char 
> *filename, int checkpoint,
>  
>      save_domain_core_writeconfig(fd, filename, config_data, config_len);
>  
> -    CHK_ERRNO(libxl_domain_suspend(ctx, domid, fd, 0, NULL));
> +    MUST(libxl_domain_suspend(ctx, domid, fd, 0, NULL));
>      close(fd);
>  
>      if (checkpoint)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel