Re: [Xen-devel] [PATCH] xl.cfg: document the maxmem= option

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Jun 01, Ian Campbell wrote:

> On Thu, 2012-05-31 at 16:04 +0100, Olaf Hering wrote:
> > +=item B<maxmem=MBYTES>
> > +
> > +Specifies the maximum amount of memory a guest can ever see.
> > +The value of maxmem= must be equal or greater than memory=.
> > +In combination with the memory= option it will start the guest 
> > "pre-ballooned".
> > +In a HVM guest it will enable the PoD (populate on demand) mode, iff the 
> > values of memory= and maxmem= differ.
> > +The guest needs a balloon driver in this case, without a balloon driver it 
> > will crash.
> 
> "iff" has proven to be confusing in the past (we keep getting "fix typo"
> patches for existing ones) maybe just spell it out? Otherwise Ack on the
> text. Although may add a note that booting a PV guest "pre-ballooned"
> Just Works?

I just send a simplified version of this patch. Mentioning PoD is not
really needed because its an hypervisor internal feature.

> Formatting wise some of these lines are very long. Can you wrap to 80
> columns please.

Done.

> Also why have you wrapped this as one sentence per line rather than
> wrapping it as paragraphs (which should have blank lines between them)?

Just a habit.

> I think maxmem= should be B<maxmem=> and the same for memory=.

Done.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel