Re: [Xen-devel] [PATCH 08 of 11] xl: add more NUMA information to `xl info -n'

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 31/05/12 15:24, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH 08 of 11] xl: add more NUMA information to `xl info 
> -n'"):
> > So that the user knows how much memory there is on each node and
> > how far they are from each others.
> Perhaps the json output machinery can do this for us ?  If that's
> sufficiently legible then it would be an improvement on this
> open-coded printer.
That sounds like a different patch series -- after all, the topology 
info is also "open-coded" at the moment.  I think there's enough work to 
do with the NUMA placement stuff for now. :-)
My only nit (somewhat pedantic) is that "x / (1 << n)" will come up with 
exactly the same answer as "x >> n", but with a very fast bit-shift 
rather than a very slow integer divison.  Not that it matters for this 
purpose; but it does make the expression more complicated-looking than 
it needs to me.
But other than that, I think this patch is probably good as it is.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel