[Xen-devel] page_list_splice() seems buggy (4.1.2)

[Jisoo Yang <jisooy@xxxxxxxxx>]

Hello,

It looks like page_list_splice(list, head) in include/xen/mm.h is buggy. (4.1.2)

After calling it, head->next.prev incorrectly points to the old first page, when it really should point to null (i.e., PAGE_LIST_NULL). 
The 'head' list becomes inconsistent and the system will crash later when you pop items out from the list. (usually fatal page fault) .

To patch this bug I suggest to remove 'first->list.prev = page_to_pdx(head->next);' line.

This bug was discovered while I was doing a private project, and the suggested patch above seems to fix it.

Thanks,
-J



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel