Re: [Xen-devel] [PATCH 4/4] x86, CPU, AMD: Deprecate AMD-specific MSR variants

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Jun 01, 2012 at 04:52:38PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@xxxxxxx>
> 
> Now that all users of {rd,wr}msr_amd_safe have been fixed, deprecate its
> use by making them private to amd.c and adding warnings when used on
> anything else beside K8.
> 

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> ---
>  arch/x86/include/asm/msr.h |   27 ---------------------------
>  arch/x86/kernel/cpu/amd.c  |   33 +++++++++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+), 27 deletions(-)
> 
> diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
> index 81860cc012d1..cb33b5f00267 100644
> --- a/arch/x86/include/asm/msr.h
> +++ b/arch/x86/include/asm/msr.h
> @@ -211,33 +211,6 @@ do {                                                     
>        \
>  
>  #endif       /* !CONFIG_PARAVIRT */
>  
> -static inline int rdmsrl_amd_safe(unsigned msr, unsigned long long *p)
> -{
> -     u32 gprs[8] = { 0 };
> -     int err;
> -
> -     gprs[1] = msr;
> -     gprs[7] = 0x9c5a203a;
> -
> -     err = rdmsr_safe_regs(gprs);
> -
> -     *p = gprs[0] | ((u64)gprs[2] << 32);
> -
> -     return err;
> -}
> -
> -static inline int wrmsrl_amd_safe(unsigned msr, unsigned long long val)
> -{
> -     u32 gprs[8] = { 0 };
> -
> -     gprs[0] = (u32)val;
> -     gprs[1] = msr;
> -     gprs[2] = val >> 32;
> -     gprs[7] = 0x9c5a203a;
> -
> -     return wrmsr_safe_regs(gprs);
> -}
> -
>  #define checking_wrmsrl(msr, val) wrmsr_safe((msr), (u32)(val),              
> \
>                                            (u32)((val) >> 32))
>  
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 80ccd99542e6..c928eb26ada6 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -19,6 +19,39 @@
>  
>  #include "cpu.h"
>  
> +static inline int rdmsrl_amd_safe(unsigned msr, unsigned long long *p)
> +{
> +     struct cpuinfo_x86 *c = &cpu_data(smp_processor_id());
> +     u32 gprs[8] = { 0 };
> +     int err;
> +
> +     WARN_ONCE((c->x86 != 0xf), "%s should only be used on K8!\n", __func__);
> +
> +     gprs[1] = msr;
> +     gprs[7] = 0x9c5a203a;
> +
> +     err = rdmsr_safe_regs(gprs);
> +
> +     *p = gprs[0] | ((u64)gprs[2] << 32);
> +
> +     return err;
> +}
> +
> +static inline int wrmsrl_amd_safe(unsigned msr, unsigned long long val)
> +{
> +     struct cpuinfo_x86 *c = &cpu_data(smp_processor_id());
> +     u32 gprs[8] = { 0 };
> +
> +     WARN_ONCE((c->x86 != 0xf), "%s should only be used on K8!\n", __func__);
> +
> +     gprs[0] = (u32)val;
> +     gprs[1] = msr;
> +     gprs[2] = val >> 32;
> +     gprs[7] = 0x9c5a203a;
> +
> +     return wrmsr_safe_regs(gprs);
> +}
> +
>  #ifdef CONFIG_X86_32
>  /*
>   *   B step AMD K6 before B 9730xxxx have hardware bugs that can cause
> -- 
> 1.7.9.3.362.g71319

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel