Re: [Xen-devel] [PATCH 0/5] crash: Small bundle of fixes for Xen

[Dave Anderson <anderson@xxxxxxxxxx>]

----- Original Message -----
> 
> 
> ----- Original Message -----
> > On Thu, Jul 05, 2012 at 05:29:50PM +0200, Daniel Kiper wrote:
> > > On Thu, Jul 05, 2012 at 11:15:29AM -0400, Dave Anderson wrote:
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > Hi,
> > > > >
> > > > > It looks that Xen support for crash have not been maintained
> > > > > since 2009. I am trying to fix this. Here it is small
> > > > > bundle of fixes:
> > > > >   - xen: Always calculate max_cpus value,
> > > > >   - xen: Read only crash notes for onlined CPUs,
> > > > >   - x86/xen: Read variables from dynamically allocated
> > > > >   per_cpu
> > > > >   data,
> > > > >   - xen: Get idle data from alternative source,
> > > > >   - xen: Read data correctly from dynamically allocated
> > > > >   console
> > > > >   ring
> > > > >   too.
> > > > >
> > > > > Daniel
> > > >
> > > > Daniel,
> > > >
> > > > Can you absolutely confirm that these changes are all
> > > > backwards-compatible?
> > > 
> > > I have not done tests with older versions of Xen. However,
> > > I made all patches with backward compatibility in mind. Anyway,
> > > If you wish I could do tests with let's say Xen Ver. 3.4
> > > and Xen Linux Kernel Ver. 2.6.18 at least.
> > 
> > I think Dave is worried about it breaking with the version that is bundled
> > with RHEL5U8?
> 
> Correct...
> 
> Dave
>  

And as it turns out, it does break RHEL5 xen, at least the changes
you made for the log command:

  crash> log
  log: invalid kernel virtual address: 616e69625f64616f  type: "conring 
contents"
  crash>

Dave


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel