Re: [Xen-devel] [PATCH] qemu-xen-traditionnal, Fix dirty logging during migration.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 23 Jul 2012, Anthony PERARD wrote:
> On Mon, Jul 23, 2012 at 11:53 AM, Anthony PERARD
> <anthony.perard@xxxxxxxxxx> wrote:
> >>
> >> Considering that on qemu-xen-traditional there is just one caller of
> >> qemu_invalidate_entry, that is cpu_physical_memory_unmap, we can just
> >> add the xc_hvm_modified_memory call there and avoid introducing
> >> xen_ram_addr_from_mapcache.
> >>
> >
> > OK, that would simplifies things.
> 
> I would need to pass an extra parametter to qemu_invalidate_entry, the size.
> I could also add a second extra parametter, was_written, and so only
> call xc_hvm_modified_memory when necessary.

I think it is still better than adding a new function with similar code

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel