Re: [Xen-devel] [PATCH 2/2] xl: support xend empty cdrom device syntax

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-07-25 at 16:37 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 2/2] xl: support xend empty cdrom device 
> syntax"):
> > On Wed, 2012-07-25 at 16:22 +0100, Ian Jackson wrote:
> > > +This is soley for compatibility with xend's syntax for empty cdroms,
> > > +which is (for example) ",hdc:cdrom,r".
> > 
> > Perhaps we should tighten the special case to specifically only
> > accept ,<vdev>:cdrom,<access> ? (and actually as it happens <access> has
> > to be "r" too)
> 
> I don't think that's necessary.  We don't intend to introduce any
> formats containing `:' so no ambiguity is introduced.
> 
> > Also perhaps it would be useful to always give the mapping to the
> > non-deprecated syntax?
> 
> You mean to write the non-deprecated syntax in the document ?

e.g.:

         The following syntax is also supported:
         
           ,<vdev>:<devtype>,<access>   (deprecated)
         
         This is soley for compatibility with xend's syntax for empty cdroms,
         which is (for example) ",hdc:cdrom,r".
        
        +The non-deprecated syntax is:
        + 
        +  ,,<vdev>:<devtype>,<access>


or whatever the most preferable non-deprecated version is. Basically it
gives a no-brainer way to update your syntax.

BTW my MUA's spell checker thinks you meant solely.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel